You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This needs a new counter during decoding. We don't actually need a predicate for “zero size type”, it should suffice (and be simpler) to notice when the buffer pointer did not get moved.
This needs to happen also in the skipping code in the rust rts, I believe. I ought to double check if the spec is clear about that and whether the test suite covers both variants (space bomb in ignored and not-ignored parts of the message.)
Candid spec compliance is presumably kinda important, if only because it looks odd if not; so maybe worth putting on the internal JIRA?
The text was updated successfully, but these errors were encountered:
The Candid spec has been updated (https://togithub.com/dfinity/candid/issues/434) and now the test suite now longer passes (#4013). Someone needs to update Motoko.
This needs a new counter during decoding. We don't actually need a predicate for “zero size type”, it should suffice (and be simpler) to notice when the buffer pointer did not get moved.
This needs to happen also in the skipping code in the rust rts, I believe. I ought to double check if the spec is clear about that and whether the test suite covers both variants (space bomb in ignored and not-ignored parts of the message.)
Candid spec compliance is presumably kinda important, if only because it looks odd if not; so maybe worth putting on the internal JIRA?
The text was updated successfully, but these errors were encountered: