feat: INF-1395: Update common after split #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
changed the title
nomeata
reviewed
Jul 27, 2020
|
Turns out the previous version common was somewhat old (3rd of June). There are some issues (failures) that seem unrelated to the changes in INF-1395. I'm leaving this as draft until I figure out why common wasn't updated; if needed I'll perform the upgrade. |
nmattia
force-pushed
the
nm-split
branch
2 times, most recently
from
9d475ea
to
536007d
Compare
The `common` repository was changed to simplify the use of `gitOnlySource`.
The move from 1.41 to 1.43 involves some new lint warnings that are fixed by this commit.
basvandijk
approved these changes
Jul 30, 2020
hansl
approved these changes
Jul 31, 2020
dfinity-bot
added a commit
that referenced
this pull request
Apr 14, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@bc824311...22b59ea8](rustsec/advisory-db@bc82431...22b59ea) * [`ce4db769`](rustsec/advisory-db@ce4db76) Update CVE numbers ([RustSec/advisory-db#870](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/870)) * [`22b59ea8`](rustsec/advisory-db@22b59ea) Add std CVE ([RustSec/advisory-db#869](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/869))
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@bc824311...22b59ea8](rustsec/advisory-db@bc82431...22b59ea) * [`ce4db769`](rustsec/advisory-db@ce4db76) Update CVE numbers ([RustSec/advisory-db#870](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/870)) * [`22b59ea8`](rustsec/advisory-db@22b59ea) Add std CVE ([RustSec/advisory-db#869](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/869))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to https://github.com/dfinity-lab/dfinity/pull/4669, the split simplifies the code. There's also a few new lint warnings from Rust 1.43 that were fixed.