Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul TextMate syntax highlighting #26

Merged
merged 16 commits into from
Jun 12, 2022
Merged

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Jun 4, 2022

Continuation of #23. The current TextMate language specification is almost directly based on Swift, so this PR fixes most of the remaining syntax highlighting and namespace issues.

This PR also adds a minimal .vscodeignore file as encouraged by the vsce package command.

Works as expected on Ubuntu (WSL) using the latest version of VSCode.

@rvanasa
Copy link
Contributor Author

rvanasa commented Jun 12, 2022

(@kritzcreek)

Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine. I don't know much about TextMate grammars, but if this floats your boat, then you have my blessing! We can certainly improve this iteratively if issues show up.

Thanks for the contribution!

@ggreif ggreif added the enhancement New feature or request label Jun 12, 2022
@ggreif ggreif merged commit 4901892 into dfinity:master Jun 12, 2022
@rvanasa
Copy link
Contributor Author

rvanasa commented Jun 12, 2022

Thank you! The grammar file will definitely require a few more iterations, but at least this is now on par with the syntax highlighting in Motoko Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:agreed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants