New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI AppVeyor #38
CI AppVeyor #38
Conversation
@mhujer good job 👍 |
@mhujer it looks like, that because you haven't specified a tests directory, it's running all the tests it can find, including those from |
Thanks, I didn't notice that. e048e6d fixes the problem. After this one is merged, I plan to create similar setups for |
I've squashed the commits. |
👍 |
dc3b9cd
to
2ae8d89
Compare
@dg Should I rebase the PR? |
@mhujer in this project the default branch is v2.x and master is rebased on v2.x. And yes, it is stupid. |
I thought, that 2.x is just for maintenance releases. Nevermind. Should I close this one and create another PR for the v2.x branch? And should I create another PR adding it as a note into https://github.com/dg/texy/blob/v2.x/contributing.md? |
Ad testing on Windows: it is really cool and useful for dibi, NDB, Tracy, Nette Http, etc. Do you think it is helpful for Texy? ad master: it is a historical problem, but I'd like to close v2.x and start using master normally. So please rebase it. |
@mhujer wait please a minute… |
@mhujer master is ready now |
@dg thanks for cleaning up the branches. I've rebased the PR. Ad. testing on Windows: I think it can be useful to at least detect differences in newlines handling (other reason was that texy does not have many dependencies, so the setup was easy). |
Texy normalizes line endings independently on OS Line 55 in 8192b89
(PR for dibi is here dg/dibi#193) |
You are right, setting it up for dibi and other projects which are more dependant on the system is definitely more useful. |
This PR adds a config file for AppVeyor which is a CI similar to travis, except they run the builds on Windows machines. Therefore any possible incompatibilites can be easily discovered.
You can see the build output here https://ci.appveyor.com/project/mhujer/texy/build/job/3pu7cfwodc77gg5p
To integrate it with this project, it is necessary to login to https://ci.appveyor.com/ using github account and enable the build for this repo.
(Symfony has recently started to use AppVeyor - symfony/symfony#15575, that's where most of the config comes from)