Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse through mpr and mpt settings header. #12

Closed
PeterKraus opened this issue Jan 19, 2022 · 6 comments
Closed

Parse through mpr and mpt settings header. #12

PeterKraus opened this issue Jan 19, 2022 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@PeterKraus
Copy link
Contributor

The param_map in eclabtechniques.py is incomplete for many parameters. It should be possible to complete it using a systematic set of mpr/mpt files.

@PeterKraus
Copy link
Contributor Author

A full set of mpt, mps, and mpr files may be necessary to fully flesh out this map.

@KarimElgammal
Copy link

Hi Peter,

thanks for your effort in yadg and the whole team

I was wondering if I need to edit 'param_from_key' to acount for 'ValueError: element '115' for parameter 'I_range' not understood.'

@KarimElgammal
Copy link

hi!
in parsing mpr file, I seen you added raise NotImplementedError("Unknown parameter offset or technique dtype.") while filling 'params_offset'

I wonder how can I read the offsets for my files, then I can add them, do you have another parser for binary somewhere?

@PeterKraus
Copy link
Contributor Author

Hi Karim, I think the easiest way would be to export the mpr file into an mpt file using EC-Lab, and then compare and implement the missing parameters. Note that we're currently not supporting files generated by EC-Lab 11.50.

@PeterKraus
Copy link
Contributor Author

I ranges up to 130 added in #153.

@PeterKraus
Copy link
Contributor Author

Mostly fixed in #193. Further fixes in #196.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants