Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Module while parsing mpr file #37

Closed
ileu opened this issue Mar 2, 2022 · 5 comments · Fixed by #40
Closed

Missing Module while parsing mpr file #37

ileu opened this issue Mar 2, 2022 · 5 comments · Fixed by #40
Assignees
Labels
bug Something isn't working electrochem
Milestone

Comments

@ileu
Copy link

ileu commented Mar 2, 2022

The attached mpr file contains an addition model called VMP ExtDev.
test.zip

@PeterKraus PeterKraus added bug Something isn't working electrochem labels Mar 2, 2022
@PeterKraus PeterKraus added this to the 4.1 milestone Mar 2, 2022
@ileu
Copy link
Author

ileu commented Mar 2, 2022

I dont know if this is the right place for it.
But I just noticed that if you just open an mpr and chose export as text, EClab will generate automatically additional data columns and save them inside the mpr file. The two attached files are the same file, before and after clicking and export as text.
OpeningFiles.zip

@PeterKraus
Copy link
Contributor

That's pretty bad. I'll tag @vetschn in case he has any ideas. Does it happen only when you have the settings file loaded, or also when you just open the "vanilla" MPR file directly? Do we have other techniques from that instrument, or only PEIS data?

I'm puzzled by this, because I cannot figure out where the data from the external devices are within the binary format. It doesn't look like there's enough values in the ExtDev module, and also the x column that EC-Lab shows and exports and the Force/N and Temperature/°C columns that are mentioned in ExtDev do not seem to correlate.

Additionally, there's no Log module, meaning the timestamp is missing. My current hope is that I can emit a warning, parse all data that is currently known (v4.1 target), and fix this up properly in a future release (v>4.1).

@vetschn
Copy link
Contributor

vetschn commented Mar 3, 2022

Nice find! 😄

I had a quick look at it just now and my guess is that the data from the external devices is in the Analog IN 1 and Analog IN 2 columns that you see in the data. Problem there: Those values are in volts so you may have to figure out a way to convert them into N and °C, respectively.

I would imagine this ExtDev module contains some info on this conversion but how that could possibly be encoded is beyond me. Maybe you can check what kind of values you can set in the EC-Lab settings for external devices / analog inputs and try to infer something from there.

That's my two pennies worth, without access to EC-Lab it's hard to say more but I hope this helps anyway.

@PeterKraus
Copy link
Contributor

I had a feeling that might be it, as Analog IN 1 and Analog IN 2 can also be used as limits via eclib. I'm pretty sure the conversion factors are encoded in the ExtDev section, as it looks like there are two numbers (perhaps slope and intercept) in each block behind the variable name. Fortunately, we have the mpt file so I can check the conversion against something.

Thanks for your help!

@PeterKraus
Copy link
Contributor

PeterKraus commented Mar 4, 2022

The above PR #40 addresses the original issue, however the 2nd issue of EC-Lab messing with mpr files remains (see #41).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working electrochem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants