Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 register handling for R (< 3.6) #15

Open
dgkf opened this issue Jul 15, 2022 · 0 comments
Open

S3 register handling for R (< 3.6) #15

dgkf opened this issue Jul 15, 2022 · 0 comments
Labels
change::minor Feature additions
Milestone

Comments

@dgkf
Copy link
Owner

dgkf commented Jul 15, 2022

Use of namespaced S3method(...) entries in NAMESPACE is not allowed in older versions of R. This was added to interoperate with lucidate, adding entries such as:

S3method(lucidate::year,partial_time)

This isn't strictly required, but makes iteration much easier. For now, an R version minimum has been introduced in Depends, but this could be loosened if this was rewritten to not require this feature.

To do so, we'd need to remove any of these entries in NAMESPACE and incorporate vctrs-style S3 registration. Since this package is tightly coupled to vctrs already, there is no need to copy the code - it can be used directly from the vctrs namespace.

@dgkf dgkf added this to the v0.1.0 milestone Sep 30, 2022
@dgkf dgkf modified the milestones: v0.1.0, v0.1.1 Nov 7, 2022
@dgkf dgkf added the change::minor Feature additions label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change::minor Feature additions
Projects
None yet
Development

No branches or pull requests

1 participant