Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Standardise the error format, don't log.Fatal #58

Closed
pawanrawal opened this issue Oct 11, 2016 · 5 comments
Closed

Standardise the error format, don't log.Fatal #58

pawanrawal opened this issue Oct 11, 2016 · 5 comments
Assignees

Comments

@pawanrawal
Copy link
Contributor

Return appropriate error to the frontend with the status code instead of log.Fatal in case you can't Decode/Encode JSON and in other cases.

@pawanrawal pawanrawal self-assigned this Oct 11, 2016
@pawanrawal
Copy link
Contributor Author

pawanrawal commented Oct 16, 2016

Hey @Rahul-Sagore, so now whenever the status is not 200, server would send a JSON object which would have a message string. That has to be displayed instead of hard coded messages on the frontend.

@pawanrawal
Copy link
Contributor Author

@Rahul-Sagore I see that still the message displayed after Validate API is hardcoded. We need to display the message that the API returns. For e.g. validate API returns that You have already completed the quiz but frontend displays You are not authorized.

@Rahul-Sagore
Copy link
Contributor

Haven't picked this up, will do this.

@Rahul-Sagore
Copy link
Contributor

This is done for the candidate facing pages.

@pawanrawal
Copy link
Contributor Author

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants