-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhide a Hidden Accessory #1331
Comments
As far as I can see this is not a bug, but rather is by design as the current thermostat implementation does not use the thermostat-operating-status virtual device and thus it will always be hidden (it's hidden for my Honeywell thermostat as well). Right now the way Current Heating Cooling State is updates is that it uses the current temperature, mode and set point to algorithmically "estimate" what the current operating state is likely to be. In other words, if the mode is "heat" and the current temperature is below the set point, then it assumes the state is "HEAT", if the mode was "cool" and the current temperature is above the set point, then it assumes the state is "COOL". The logic is a little more complex than this, but that's the jist of it, it doesn't use the actual reporting mode. This is not a perfect implementation as it will not reflect the current operating state 100% of the time. For example, on my thermostat the Homebridge operating state will switch to "Off" as soon as the temperature rises to be the same as the set temperature, however, my thermostat will keep the unit running for quite a bit longer to get closer to the mid-point. I'm not sure why it was implemented this way vs using the thermostat-operating-status. If I remember correctly it was contributed by another user many years ago (2020) and it doesn't appear to have had any significant changes in that time, so I assume it is mostly good enough for most users. |
Took another quick glance through the code and verified that the behavior above is correct/expected as the code is written today. The thermostat-operating-status will always show as a hidden accessory because it is not listed in What probably should happen:
I know this works because I already use this same basic logic in ring-mqtt. I'll try to do this for the next version, however, that probably won't be until sometime next month as I have limited time available at the moment. For now however, I'm going to close this issue since, as currently written, it is expected that the thermostat operating status is a hidden accessory so the request about unhiding an the accessory is invalid. |
Thanks, @tsightler for the looking into this and the explanation. I had an IFTTT plugin and automation set up to log every time the thermostat changed current operating status to "heat" or "off". It was working in that it the current operating status would come on and the go off in 2 minutes even though the boiler was still heating. Based on your explanation, I now understand that to be by design or a function of the algorithm estimating the current operating status. Thanks, again. |
Is there an existing issue for this?
Describe The Bug
I have a Boiler Thermostat configured through Ring. I have hidden the Temperature Sensor (and four other accessories unrelated to the Boiler Thermostat), but for some reason the Thermostat Operating Status is also hidden even though I haven't hidden it in the HOOBS configuration settings.
I have uninstalled the plugin, removed the bridge from Home and reinstalled everything. Even with a fresh install and before I hide some of the other items like light groups and sirens and added the other accessories I wanted to hide, the only hidden accessory in the log was the Thermostat Operating Status. I'm pretty sure last winter when I was using the Boiler Thermostat the Thermostat Operating Status was not hidden because I have automations that use the Current Heating Cooling State, which no do not work now because the Boiler will be on heating (and showing that it is in heating mode in Ring app) but in Home+ the Current Healing Cooling State is "Off".
Is there some way to "unhide" the Thermostat Operating Status?
Thanks.
To Reproduce
No response
Expected behavior
I expected to be able to unhide the hidden accessory.
Relevant log output
Screenshots
No response
Homebridge Ring Config
Additional context
No response
OS
macOS
Node.js Version
16.20.2
NPM Version
?
Homebridge/HOOBs Version
1.6.0/4.3.0
Homebridge Ring Plugin Version
12.0.1
Operating System
Rasbian?
The text was updated successfully, but these errors were encountered: