Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error loading Unobot #44

Closed
dasu opened this issue Apr 13, 2017 · 6 comments
Closed

Error loading Unobot #44

dasu opened this issue Apr 13, 2017 · 6 comments
Labels

Comments

@dasu
Copy link

dasu commented Apr 13, 2017

Error loading unobot: invalid syntax (unobot.py, line 697)
Grabbed the very latest commit as of today.
I'm on python3.3. Not sure if i'm missing any potential requirements.

@dgw
Copy link
Owner

dgw commented Apr 13, 2017

Hmm… I may need to look into handling exceptions under 2.x vs 3.x. My instance is on 2.7 and doesn't throw syntax errors for that code. (Score saving error handling in general is also the least well tested bit of code, so…)

I'm out of town, so this may take a couple of weeks to track down depending on how my schedule works out. But I appreciate the report :)

@dgw
Copy link
Owner

dgw commented Apr 13, 2017

Yep, there are five (by my quick count) spots using except syntax that was removed in Python 3. I'll let you know when I get a chance to push up a branch with tentative fixes so you can test it. Probably sometime between now and the end of the week. Doubt it'll take me more than an hour with my laptop, once I find time to sit down and do it.

@dgw
Copy link
Owner

dgw commented Apr 15, 2017

Finally found a moment for this. @dasu, can you try the py3-exception-syntax branch?

@dasu
Copy link
Author

dasu commented Apr 16, 2017

I haven't tested it yet but I know it'll fail because of the print at the end. It'll work thought since I made the same changes as you.

@dgw
Copy link
Owner

dgw commented Apr 16, 2017

Ugh, I left that print in when I adopted the code, for no particular reason. I should just carve out an evening (or whatever) and make sure the whole module is compatible with both py2.7 and py3. Thanks for the nudge, though. Knowing people are running this on both gives me reason to check compatibility going forward.

@dgw
Copy link
Owner

dgw commented Feb 2, 2018

Closing in favor of #46 as a tracking issue.

@dgw dgw closed this as completed Feb 2, 2018
@dgw dgw added the support label Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants