Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaml-to-dhall --version should not require SCHEMA argument #1198

Closed
vvv opened this issue Aug 3, 2019 · 3 comments · Fixed by #1199
Closed

yaml-to-dhall --version should not require SCHEMA argument #1198

vvv opened this issue Aug 3, 2019 · 3 comments · Fixed by #1199

Comments

@vvv
Copy link
Contributor

vvv commented Aug 3, 2019

yaml-to-dhall --version should just work.

Current behaviour:

$ yaml-to-dhall --version
Missing: SCHEMA

Usage: yaml-to-dhall [-V|--version] SCHEMA [--records-strict]
                     [--no-keyval-arrays] [--no-keyval-maps] [--unions-first |
                     --unions-none | --unions-strict] [--file FILE] [--ascii]
                     [--plain]
  Convert a YAML expression to a Dhall expression, given the expected Dhall type
$ yaml-to-dhall --version ''
1.4.0
Gabriella439 added a commit that referenced this issue Aug 3, 2019
@Gabriella439
Fix --version flag handling for dhall-json package
738b902 
Fixes #1198

This changes version to be a separate constructor for options parsing,
in order to make invalid states unrepresentable and to fix issues like
the above one.
@Gabriella439 Gabriella439 mentioned this issue Aug 3, 2019
Merged
@Gabriella439
Copy link
Collaborator

Fix is up here: #1199

@vvv
Copy link
Contributor Author

vvv commented Aug 4, 2019

That was quick! 🤠 Thanks, @Gabriel439!

@Gabriella439
Copy link
Collaborator

@vvv: You're welcome! 🙂

@mergify mergify bot closed this as completed in #1199 Aug 6, 2019
mergify bot pushed a commit that referenced this issue Aug 6, 2019
@Gabriella439 @mergify
Fix --version flag handling for dhall-json package (#1199)
d66d1db 
* Fix `--version` flag handling for `dhall-json` package

Fixes #1198

This changes version to be a separate constructor for options parsing,
in order to make invalid states unrepresentable and to fix issues like
the above one.

* Undo `allowImports` changed

This was a change I forgot to stash while working on the fix for the
`--version` flag

* Fix missing `Paths_dhall_json` in `dhall-json.cabal`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --version flag handling for dhall-json package dhall-lang/dhall-haskell
2 participants
@vvv @Gabriella439