Fix --version flag handling for dhall-json package
#1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1198 This changes version to be a separate constructor for options parsing, in order to make invalid states unrepresentable and to fix issues like the above one.
This was a change I forgot to stash while working on the fix for the `--version` flag
sjakobi
reviewed
Aug 5, 2019
|
|
||
| case maybeOptions of | ||
| Nothing -> do | ||
| putStrLn (Data.Version.showVersion Meta.version) |
There was a problem hiding this comment.
Having Nothing represent the --version option seems a bit hacky. Why not use the same schema as in dhall-to-json?
There was a problem hiding this comment.
@sjakobi: It's because the option type for dhall-to-yaml it defined in a separate file and it doesn't have a Version constructor. I plan to fix that, but I wanted to keep this change as small as possible
sjakobi
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1198
This changes version to be a separate constructor for options parsing,
in order to make invalid states unrepresentable and to fix issues like
the above one.