Add support for dependent types #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as standardized in dhall-lang/dhall-lang#669
Closed
It only existed for the pre-dependent-types type-checking fast path for `let` expressions, which is gone
sjakobi
approved these changes
Aug 4, 2019
EggBaconAndSpam
added a commit
that referenced
this pull request
Aug 5, 2019
Removes the non-dependent let path. Needed since #1164 added support for general dependent types.
EggBaconAndSpam
added a commit
that referenced
this pull request
Aug 7, 2019
Removes the "fast path" when typechecking `let`s whose bound expression has a small type. This optimisation is no longer legal in the presence of dependent types (as introduced in #1164).
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2019
* Implement completion support Completes the following: - environment variables - local imports - identifiers in scope (as well as built-ins) - record projections - union constructors * Add support for general dependent types Removes the non-dependent let path. Needed since #1164 added support for general dependent types. * Remove unused import * Use monad instance to cast between `Expr Src _` As suggested by @Gabriel439: Use `typeOf (do _ <- expr; holeExpr)` instead of `fmap undefined expr`. In the absence of `Embed` constructors (in this case `Import`s) the two are equivalent. * Simplify completeFromContext Caught by @Gabriel439 * Remove debug code * Add 1s timeout to listDirectory call As pointed out by @Gabriel439, listDirectory can be a potentially expensive operation. Adding a timeout should improve the user experience. * Fix unclean merge
mergify bot
pushed a commit
that referenced
this pull request
Aug 12, 2019
* Correctly handle dependent types in dhall-lsp-server Removes the "fast path" when typechecking `let`s whose bound expression has a small type. This optimisation is no longer legal in the presence of dependent types (as introduced in #1164). * Fix bad merge * Remove redundant import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as standardized in dhall-lang/dhall-lang#669