Fix test suite in response to … #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
commented
Sep 3, 2019
sjakobi
commented
Sep 4, 2019
sjakobi
force-pushed
the
sjakobi/merge-type-tests
branch
from
51d2acf
to
bef2777
Compare
|
What would be a good platform-independent way to ensure that we don't use the (semantic) cache when resolving imports?
We could probably reuse the code for the latter alternative for a mode that lets users check their hash-protected imports… |
|
@sjakobi: So I think the right solution in the long-term is a variation on integrity checks which don't α-normalize the protected import, but in the short term we could add a |
Such a flag would also be useful to check whether hash-protected imports have changed – otherwise there's no warning. |
sjakobi
added a commit
that referenced
this pull request
Sep 7, 2019
When enabled, we handle protected imports as if the semantic cache was
empty:
* Protected imports are resolved again, downloaded or read from
the filesystem as necessary.
* Protected imports are β-normalized, not αβ-normalized.
* Protected imports are checked against their SHA256 hashes,
failing to resolve if they don't match.
Context:
#1275 (comment)
Merged
sjakobi
added a commit
that referenced
this pull request
Sep 9, 2019
When enabled, we handle protected imports as if the semantic cache was
empty:
* Protected imports are resolved again, downloaded or read from
the filesystem as necessary.
* Protected imports are β-normalized, not αβ-normalized.
* Protected imports are checked against their SHA256 hashes,
failing to resolve if they don't match.
Context:
#1275 (comment)
sjakobi
force-pushed
the
sjakobi/merge-type-tests
branch
from
0eee7fb
to
c60a583
Compare
sjakobi
commented
Sep 10, 2019
sjakobi
force-pushed
the
sjakobi/merge-type-tests
branch
from
c60a583
to
7494ae9
Compare
sjakobi
changed the title
sjakobi
force-pushed
the
sjakobi/merge-type-tests
branch
2 times, most recently
from
6cd1bcb
to
7cdb0ec
Compare
Gabriella439
approved these changes
Sep 14, 2019
sjakobi
force-pushed
the
sjakobi/merge-type-tests
branch
from
7cdb0ec
to
5a692a9
Compare
… in response to dhall-lang/dhall-lang#723.
sjakobi
force-pushed
the
sjakobi/merge-type-tests
branch
from
5a692a9
to
d8149ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dhall-lang/dhall-lang#723