Simplify ⫽ within projection #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as standardized in dhall-lang/dhall-lang#697.
sjakobi
commented
Sep 6, 2019
| ksSet = Dhall.Set.toSet ks | ||
| kvs' = Dhall.Map.restrictKeys kvs ksSet | ||
| ks' = Dhall.Set.fromSet (Data.Set.difference ksSet (Dhall.Map.keysSet kvs')) | ||
| in vPrefer env (vProjectByFields env l ks') (VRecordLit kvs') |
There was a problem hiding this comment.
I suspect that this could be refactored to be tail-recursive, but I don't expect that to change a lot performance-wise.
Gabriella439
approved these changes
Sep 6, 2019
|
Should I hold off on merging this until a release supporting Dhall-10 has been cut? The standard change was merged after the 10.0.0 release. |
|
@sjakobi: Yeah, hold off until I cut the 10.0.0 release. I will have a 10.0.0 pull request out tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as standardized in dhall-lang/dhall-lang#697.
This does not update the submodule as #1275 has to be sorted out first.