Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift context judgement #367

Closed
joneshf opened this issue Feb 9, 2019 · 2 comments · Fixed by #369
Closed

Shift context judgement #367

joneshf opened this issue Feb 9, 2019 · 2 comments · Fixed by #369

Comments

@joneshf
Copy link
Collaborator

joneshf commented Feb 9, 2019

I was reading through the semantics and ran into something that I need clarification on. In the shift context section, there are two judgements:

─────────────────
↑(d, x, m, ε) = ε


↑(d, x, m, Γ₀) = Γ₁   ↑(d, x, m, T₀) = T₁
─────────────────────────────────────────
↑(d, x, m, (Γ₀, x : T₀)) = Γ₁, x : T₁

Should there also be a judgement for the case where the variable does not match?

↑(d, x, m, Γ₀) = Γ₁   ↑(d, x, m, T₀) = T₁
─────────────────────────────────────────
↑(d, x, m, (Γ₀, y : T₀)) = Γ₁, y : T₁
@Gabriella439
Copy link
Contributor

@joneshf: Oh, whoops. That is a mistake on my part. I'll change it to use y for the second variable so that the judgment doesn't imply that the two variables need to be the same

Gabriella439 added a commit that referenced this issue Feb 12, 2019
@Gabriella439
Fix judgment for shifting contexts
072e9e8 
Fixes #367

The judgment mistakenly implies that the variable being shifted must
match each variable in the context.  This fixes the judgment to use
different variable names to avoid confusion.
@Gabriella439 Gabriella439 mentioned this issue Feb 12, 2019
Merged
@Gabriella439
Copy link
Contributor

Fix is up here: #369

Gabriella439 added a commit that referenced this issue Feb 22, 2019
@Gabriella439
Fix judgment for shifting contexts (#369)
8c0e8b5 
Fixes #367

The judgment mistakenly implies that the variable being shifted must
match each variable in the context.  This fixes the judgment to use
different variable names to avoid confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix judgment for shifting contexts dhall-lang/dhall-lang
2 participants
@Gabriella439 @joneshf