Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no more mobile version of the site #18

Closed
GoogleCodeExporter opened this issue Jul 9, 2015 · 8 comments
Closed

no more mobile version of the site #18

GoogleCodeExporter opened this issue Jul 9, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

this is mostly just a css problem, we have the old css in there and most of the 
places that check for 
mobileness still exist, we just didn't get it all running again. A few 
experiments in the 
middleware/domain.py should get it working again

Original issue reported on code.google.com by andyster on 14 Mar 2009 at 7:14

@GoogleCodeExporter
Copy link
Author

Hi Andy,
Can you add some instruction/description? I'm not sure where to start...

Original comment by tony.t.t...@gmail.com on 27 Mar 2009 at 10:58

@GoogleCodeExporter
Copy link
Author

Places to start:

We have in middleware/domain.py some stuff that looks for the 'm' subdomain and
attempts to set request.mobile = True if it finds it. Templates ought to be 
able to
look for request.mobile to see if they should be rendering themselves as a 
mobile
variant (likely including the mobile.css stuff).

Additionally, queries will likely have a slightly smaller page size if this is a
mobile site, so places like overview, explore and so on should probably check, 
also.

Original comment by andyster on 2 Apr 2009 at 8:48

  • Added labels: Size-Medium

@GoogleCodeExporter
Copy link
Author

I'm completely at a loss to where I would look to work out correcting stuff 
like this - 
if there's a css display issue I can usually work it out - eg. layouts getting 
skewed 
etc.

Original comment by alexleon...@gmail.com on 2 Apr 2009 at 9:03

@GoogleCodeExporter
Copy link
Author

jonas appears to have started work on this and made significant headway

Original comment by andyster on 16 Apr 2009 at 9:20

@GoogleCodeExporter
Copy link
Author

Initial patch has been put on rietku for review: http://rietku.appspot.com/10001

Original comment by jonasnoc...@gmail.com on 20 Apr 2009 at 7:37

@GoogleCodeExporter
Copy link
Author

Great work Jonas! Keep it up. As mentioned I'm hoping to join in as soon as 
physically 
possible.

Original comment by alexleon...@gmail.com on 20 Apr 2009 at 11:26

@GoogleCodeExporter
Copy link
Author

As a mobile version of the site is now in place (yay!), I think we should close 
this
issue. There are certainly issues left to deal with in this area but those 
should
probably be handled individually.

Original comment by jonasnoc...@gmail.com on 21 May 2009 at 10:17

@GoogleCodeExporter
Copy link
Author

Original comment by adewale on 21 May 2009 at 10:43

  • Changed state: Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant