Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs Typescript support #13

Closed
ggedde opened this issue Nov 11, 2019 · 6 comments
Closed

Needs Typescript support #13

ggedde opened this issue Nov 11, 2019 · 6 comments
Assignees
Labels
enhancement 💄 New feature or request good first issue 🔰 Good for newcomers

Comments

@ggedde
Copy link

ggedde commented Nov 11, 2019

This looks like a very simple and easy to use plugin, but I am using Typescript and getting errors as there is no Types enabled for vue-debounce.

If it will take too long to add could you maybe advise on how to declare a declaration for vue-debounce.

Thanks

@ggedde
Copy link
Author

ggedde commented Nov 11, 2019

PS here is the error I am getting:

Could not find a declaration file for module 'vue-debounce'. '.../node_modules/vue-debounce/dist/vue-debounce.min.js' implicitly has an 'any' type.
  Try `npm install @types/vue-debounce` if it exists or add a new declaration (.d.ts) file containing `declare module 'vue-debounce';`

@dhershman1
Copy link
Owner

Hello @ggedde ! Thanks for using my little plugin! I don't use typescript much at all, I've written index.d files for my other libs but I'm not quite sure how I would do something similar for this one.

I know it's possible I will just have to look into how to accomplish this, it may be faster if you want to open a PR to create a index.d.ts file in the meantime. (I am going to talk to my buddy who uses typescript so that might take time)

@dhershman1 dhershman1 added the enhancement 💄 New feature or request label Nov 12, 2019
@dhershman1 dhershman1 self-assigned this Nov 12, 2019
@ggedde
Copy link
Author

ggedde commented Nov 12, 2019

Thanks @dhershman1
Unfortunately, I don't know how to create one either.
I have looked at others and tried to discuss it on discord with the vue typescript community, but no luck so far.

@dhershman1
Copy link
Owner

Thanks, like I said I've done it before but this one is a little different than those other tools. I know my friend is gonna take a look at it for me however.

@dhershman1 dhershman1 added the good first issue 🔰 Good for newcomers label Nov 19, 2019
@dhershman1
Copy link
Owner

#14 opened after switching which branch the PR is directed at it should be good to go.

@ggedde
Copy link
Author

ggedde commented Dec 19, 2019

Thanks, New update working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💄 New feature or request good first issue 🔰 Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants