fix: report view as MAP_VIEW not VISUALIZATION_VIEW (DHIS2-16250) #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3086--dhis2-maps.netlify.app |
4 flaky tests on run #2811 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Thematic Layers > adds a thematic layer for OU Bombali |
Screenshots
|
|
systemsettings.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| systemSettings > includes Weekly period type when weekly periods not hidden in system settings |
Screenshots
|
|
dataDownload.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Data Download > downloads data from a thematic layer |
Screenshots
|
|
interpretations.cy.js • 1 flaky test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Interpretations > view interpretation after creating a map |
Screenshots
|
|
Review all test suite changes for PR #3086 ↗︎
janhenrikoverland
approved these changes
Dec 20, 2023
janhenrikoverland
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Dec 21, 2023
## [100.2.3](v100.2.2...v100.2.3) (2023-12-21) ### Bug Fixes * conditionally set PR title in dhis2-verify-app workflow ([#3089](#3089)) ([03eed2d](03eed2d)) * report as MAP_VIEW not VISUALIZATION_VIEW ([#3086](#3086)) ([008e7fe](008e7fe)) * **translations:** sync translations from transifex (dev) ([dcf7743](dcf7743)) * **translations:** sync translations from transifex (dev) ([7d98a8a](7d98a8a)) * **translations:** sync translations from transifex (dev) ([6e8b82b](6e8b82b))
|
🎉 This PR is included in version 100.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dhis2.atlassian.net/browse/DHIS2-16250
The view count should still be correct in the Interpretations and Details panel.