Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C4GT] Chain-Space: Add tests for InvalidIdentifier #279

Open
3 tasks
vatsa287 opened this issue Feb 5, 2024 · 5 comments
Open
3 tasks

[C4GT] Chain-Space: Add tests for InvalidIdentifier #279

vatsa287 opened this issue Feb 5, 2024 · 5 comments
Labels

Comments

@vatsa287
Copy link
Member

vatsa287 commented Feb 5, 2024

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-chain-space after adding it in the code.

Goals

  • Add tests for InvalidIdentifier for pallet/chain-space

Expected Outcome

  • Test should assert for InvalidIdentifier being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: creating_a_duplicate_space_should_fail which validates error code SpaceAlreadyAnchored

Mockups / Wireframes

NA


Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Medium]

Category

[Test]

Sub Category

[Beginner friendly]

@rising0raj
Copy link

hey @vatsa287 I would like to work on this . I have gone through the code base can you assign this to me if it is open??

@Sohajawdekar
Copy link

Hey @vatsa287 !
I am interested in contributing to this project and reviewed the prerequisites and code. Can you please assign this issue to me ?

@hardik-pratap-singh
Copy link
Contributor

Hey @vatsa287 @amarts !
I would love to work on this issue.
Kindly assign it to me if possible !

@VedantKhairnar
Copy link

Hello @hardik-pratap-singh
Are you still interested in contributing to the issue?
Thanks.

@hardik-pratap-singh
Copy link
Contributor

@VedantKhairnar Go ahead. I am busy with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants