Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on attempted conversion of json created by 2023.4 #168

Closed
erevrav opened this issue Nov 1, 2023 · 2 comments
Closed

crash on attempted conversion of json created by 2023.4 #168

erevrav opened this issue Nov 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@erevrav
Copy link
Collaborator

erevrav commented Nov 1, 2023

Describe the bug

To Reproduce
Windows 11, ran jamstats artifact from Oct 31 (with color fix), feed it json created by crg 2023.4 (technically a fork of it, but I hypothesize that's not relevant).

Expected behavior
expected pdf. got crash:

jamstats version 1.4.1, by Damon May
Mode not specified. Inferred mode pdf
Output filepath not provided. Using input filepath with extension .pdf instead of .json
Writing PDF file...
Using theme white
[76744] Failed to execute script 'jamstats' due to unhandled exception!
Traceback (most recent call last):
  File "pandas\core\groupby\generic.py", line 341, in array_func
  File "pandas\core\groupby\ops.py", line 1016, in _cython_operation
  File "pandas\core\groupby\ops.py", line 677, in cython_operation
  File "pandas\core\groupby\ops.py", line 508, in _cython_op_ndim_compat
  File "pandas\core\groupby\ops.py", line 563, in _call_cython_op
  File "pandas\core\groupby\ops.py", line 205, in get_cython_func_and_vals
  File "pandas\core\groupby\ops.py", line 171, in _get_cython_function
NotImplementedError: function is not implemented for this dtype: [how->mean,dtype->object]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "jamstats", line 255, in <module>
  File "jamstats", line 251, in __main__
  File "jamstats\plots\plot_together.py", line 93, in save_game_plots_to_pdf
  File "jamstats\plots\plot_together.py", line 67, in make_all_plots
  File "jamstats\plots\basic_plots.py", line 46, in plot
  File "jamstats\data\game_data.py", line 239, in build_team_jammersummary_df
  File "pandas\core\groupby\generic.py", line 979, in aggregate
  File "pandas\core\apply.py", line 161, in agg
  File "pandas\core\apply.py", line 436, in agg_dict_like
  File "pandas\core\apply.py", line 436, in <dictcomp>
  File "pandas\core\groupby\generic.py", line 243, in aggregate
  File "pandas\core\groupby\groupby.py", line 1690, in mean
  File "pandas\core\groupby\generic.py", line 352, in _cython_agg_general
  File "pandas\core\groupby\generic.py", line 348, in array_func
  File "pandas\core\groupby\groupby.py", line 1398, in _agg_py_fallback
  File "pandas\core\groupby\ops.py", line 1060, in agg_series
  File "pandas\core\groupby\ops.py", line 1085, in _aggregate_series_fast
  File "pandas\_libs\reduction.pyx", line 297, in pandas._libs.reduction.SeriesGrouper.get_result
AssertionError: `result` has not been initialized.

Additional context
running CRG from https://github.com/katpet/scoreboard/releases/tag/v2023.4_pbt_v0.3, which is up to date with mainline crg and this is (probably) something far away from those changes.

@erevrav erevrav added the bug Something isn't working label Nov 1, 2023
@erevrav
Copy link
Collaborator Author

erevrav commented Nov 1, 2023

(the jsons from the other 4 games that weekend work fine with the artifact from Oct 31.)

@dhmay
Copy link
Owner

dhmay commented Nov 16, 2023

I believe this is fixed in 1.4.2.

@dhmay dhmay closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants