Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGREPORT - Additional Options not functioning on WebServer #76

Closed
bullseye555 opened this issue Jan 7, 2023 · 2 comments
Closed

BUGREPORT - Additional Options not functioning on WebServer #76

bullseye555 opened this issue Jan 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@bullseye555
Copy link
Contributor

Describe the bug
I initially thought this may have just been a GUI bug, but it's happening in commandline too. I've validated the PDF outputs are all working as expected [except Anonymizeteams which has the same failure]

All options below have been generated using command line, but the same issue occurs when initiate through the GUI

  • Selecting a theme doesn't change the theme of any of the plots
  • Selecting Anonymize doesn't anonymize skaters
  • Anonymize Teams fails to run
  • Team Colors don't set

To Reproduce
Windows Server 2019 and Windows 11 (both 64 bit), run via GUI or via command line with a WebServer as the Output method

Expected behavior
Plots change from standard theme to a dark-theme when the relevant theme is chosen, Teams/Players are anonymised, Team Colours are overridden

Screenshots
Lead and Scores shown for reference, but all fields validated as not presenting differently
image
image
image

(Dark Grids PDF export on the left next to a No Theme export on the right for comparative reference)
image

Skater Names not Anon
image

Anonymize Teams fails
image
image

Team Colors don't update
image
When I was first looking at this, the Cumulative Score by Jam had the right colours, but then it stopped after I navigated away and came back and it was the wrong colour again. I haven't been able to reproduce the correct colours again
image
[For reference, the CRG loaded team colours for this are Black and Yellow, too, so it's not picking up the CRG loaded colours either -- unless you're picking up the Scoreboard colours?
image
image

Additional context
Cache cleared between tests, and ran in incognito mode with same result

Anonymizing Teams Debug Output

C:\Users\Administrator\Desktop>jamstats.exe --jsonfile c:\users\administrator\desktop\KCRvWSRD.json --outfile c:\users\administrator\desktop\kcr_anonTeam_debug.pdf --anonymizeteams --debug
jamstats version 0.3.4, by Damon May
Enabling debug logging.
load_json_derby_game start.
JSON major version string: v5
Loading game data
JSON major version string: v5
Found version 5. Checking for in-progress game...
Extracting roster
extract_roster begin
JSON version 5
Looking for teams in roster: Team\(1\), Team\(2\)
Roster rows by team:
1    541
2    484
Name: team, dtype: int64
Loaded roster. Skater count by team:
Sovereigns    13
Wreckers      12
Name: team, dtype: int64
Extracting jam data
Found 14816 Period rows.
Found 14690 Jam rows.
Found 54 jams.
Jam simple fields: Index(['Previous', 'Id', 'WalltimeStart', 'WalltimeEnd', 'StarPass',
       'Readonly', 'Duration', 'PeriodNumber', 'PeriodClockElapsedEnd',
       'PeriodClockDisplayEnd', 'Overtime', 'Number',
       'PeriodClockElapsedStart', 'Next'],
      dtype='object')
Jams summary rows: 54
Jams summary rows (without 0:00): 53
Jams: 53
teamjam rows, team 1: 7035
teamjam simple fields: Index(['OsOffsetReason', 'Previous', 'Readonly', 'AfterSPScore', 'StarPass',
       'StarPassTrip', 'TotalScore', 'Number', 'OsOffset', 'Next', 'NoPivot',
       'NoInitial', 'Calloff', 'Lost', 'Lead', 'LastScore', 'JamScore',
       'Injury', 'Id', 'DisplayLead', 'CurrentTripNumber', 'CurrentTrip'],
      dtype='object')
teamjams pivoted rows: 54
After adding jammer info: 54
extract_team_perjam_skaters begin
    Before roster merge, team jam skater data: 270
    After roster merge, team jam skater data: 254
    Jam skater lists length: 53
After adding skaters/jam: 53
Loaded 54 scoring trips.
After adding scoring trips: 53
teamjam rows, team 2: 6876
teamjam simple fields: Index(['OsOffset', 'OsOffsetReason', 'Previous', 'Readonly', 'AfterSPScore',
       'StarPass', 'StarPassTrip', 'NoPivot', 'TotalScore', 'Number', 'Next',
       'NoInitial', 'Calloff', 'Lost', 'Lead', 'LastScore', 'JamScore',
       'Injury', 'Id', 'DisplayLead', 'CurrentTripNumber', 'CurrentTrip'],
      dtype='object')
teamjams pivoted rows: 54
After adding jammer info: 54
extract_team_perjam_skaters begin
    Before roster merge, team jam skater data: 270
    After roster merge, team jam skater data: 238
    Jam skater lists length: 53
After adding skaters/jam: 53
Loaded 54 scoring trips.
After adding scoring trips: 53
After merging teamjams: 53
Made jams summary dataframe. Rows: 53
Extracting penalties
extract_penalties begin
    Rows with `Penalty(`: 252
    After merging with roster: 252
    Before merge with penalty codes: 18
build_penalty_code_name_map begin, version==5
Built penalty code dataframe: 15 codes
Extracted penalties: 18 rows.
Team colors: Empty DataFrame
Columns: [team, color]
Index: []
DerbyGame init
Extracting game summary dict
extract_game_summary_dict 1
Periods: 2
Jams: 53
Extracting jam data for period {period}
Extracting jam data for period {period}
Calculating final scores
Handling team colors
Failed to find teams in color definitions. Dummying.
Anonymizing teams.
Traceback (most recent call last):
  File "jamstats", line 116, in <module>
AttributeError: 'DerbyGame' object has no attribute 'anonymize_teams'
[10656] Failed to execute script 'jamstats' due to unhandled exception!
@bullseye555 bullseye555 added the bug Something isn't working label Jan 7, 2023
This was referenced Jan 7, 2023
@dhmay
Copy link
Owner

dhmay commented Jan 7, 2023

I believe I've fixed all this stuff in the bugfix4 branch, will merge today.

@dhmay dhmay closed this as completed Jan 7, 2023
@bullseye555
Copy link
Contributor Author

Confirming Bugfix4 branch exe has these functions working on Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants