DEPRECATED Action signature

[seisfeld]

Hi,

i'm getting the following warning when running atnetgo (which is really nice btw):

DEPRECATED Action signature. Must be cli.ActionFunc. This is an error in the application. Please contact the distributor of this application if this is not you. See https://github.com/codegangsta/cli/blob/master/CHANGELOG.md#deprecated-cli-app-action-signature

Is this fixable? I can't submit a pull request though because i don't know go.

Thanks
Stephan

[dhogborg]

This is due to me using a old seed for the codegangsta/cli code. It's a really easy to fix and if you want to do it I'll be happy to merge your pull request, but I think I can fix it quite quickly.

[seisfeld]

Thanks for the quick reply. As said before i have no clue about go, so i can't submit a pull request.

[dhogborg]

Starting with commit 2683fa2 the libs are vendorized. That means building will always use the same version of lib that was used during development. Errors like this should therefore not happen again.

Also, see https://github.com/dhogborg/atnetgo/releases for prebuilt binary downloads.

[seisfeld]

Unfortunately i still get the same message. Here is what i did:

I removed my whole go stuff and just did:

go get -v github.com/dhogborg/atnetgo

It then builds end exits with an error:

# github.com/dhogborg/atnetgo
src/github.com/dhogborg/atnetgo/main.go:82: undefined: NetatmoAppID
src/github.com/dhogborg/atnetgo/main.go:83: undefined: NetatmoAppSecret

So i went into the directory and created the secrets.go as per the instructions and did rerun the command above which then works leaving me with the atnetgo binary. When i run it, i still get the message. What am i missing?

[dhogborg]

You need to use godep to build with the vendorized libs. (https://github.com/tools/godep)
Go in to the atnetgo project folder. Run the following commands:

make setup
make

You can specify which platform to build with make <platform> Look in Makefile for platforms already configured.

I will update the readme with more detail build instructions later.

If you don't need to make changes to the source then I would suggest using the binary I built, you can find it under Releases here on github. :)

[seisfeld]

I tried that, does not work either. I'll wait for the build instructions then.

BTW: I find the --station and --module options don't have any effect. Can that be related to that i did built this incorrectly?

[dhogborg]

The build instructions are up to date in the README as of just now.

The filtering by --station flag is back in action, while the --module has been removed due to incompatibility with the netatmo lib API. Use grep for module filtering.

[seisfeld]

Hi again,

you still refer to the --module option in your build instructions (#6). Beside that i got it working now by running the following:

1. make setup
2. godep restore
3. make build

Thanks for the help! :)

cheers
Stephan

[dhogborg]

I will get remove the --module shortly. :)

If godep is of a reasonable late version and your Go environment is 1.5 or later godep restore should not be needed as the $GOPATH is rewritten by godep to include the vendor folder where the "frozen" library code is placed.

But anyway! Good to hear that you got it working!

[seisfeld]

That's probably the issue then. I run this on an Ubuntu 14.04 LTS server. go version shows go version go1.2.1 linux/arm. But anyways. I got it running. :) Thanks again for your assistance and great simple tool.