Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Filter List Page #1531

Closed
dhowe opened this issue Jul 23, 2019 · 5 comments
Closed

Issues with Filter List Page #1531

dhowe opened this issue Jul 23, 2019 · 5 comments

Comments

@dhowe
Copy link
Owner

dhowe commented Jul 23, 2019

-[ ] vertical alignment of 'ignore...' checkbox
-[ ] custom button should contain import button
-[ ] missing text-area to enter custom items

image

image

@cqx931
Copy link
Collaborator

cqx931 commented Jul 23, 2019

-[ ] missing text-area to enter custom items

This is not a bug in adnauseam. If you click import, the text area will show up, which is the same behavior as the one in uBlock origin

@cqx931
Copy link
Collaborator

cqx931 commented Jul 23, 2019

In this ticket, you mentioned that ignoreGenericCosmeticFilters is not relevant to AdNauseam. So we should keep hidden and unhide an option that has been mistakenly hidden instead:
image

@cqx931
Copy link
Collaborator

cqx931 commented Jul 23, 2019

Also I'm not sure whether custom should hide import button if that is what you mean by 'contain'. This is currently the design choice by uBlock and the hiding view only hide filters that are not in use.

cqx931 added a commit to cqx931/AdNauseam that referenced this issue Jul 23, 2019
@cqx931
Copy link
Collaborator

cqx931 commented Jul 23, 2019

Other minor tweaks are done here: e4d767d

@cqx931
Copy link
Collaborator

cqx931 commented Aug 3, 2019

@dhowe can this be closed now?

@dhowe dhowe closed this as completed Aug 3, 2019
@cqx931 cqx931 mentioned this issue Sep 19, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants