Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not properly block video ads on YouTube, Twitch, &c. #234

Closed
Fleckeri opened this issue Jun 11, 2016 · 12 comments
Closed

Does not properly block video ads on YouTube, Twitch, &c. #234

Fleckeri opened this issue Jun 11, 2016 · 12 comments

Comments

@Fleckeri
Copy link

I may not have configured it properly, but using AdNauseum does not block video ads that disrupt YouTube, Twitch, and other similar video streaming sites like uBlock does. Is there anything I can do to fix this, or is this an upcoming feature?

@dhowe
Copy link
Owner

dhowe commented Jun 11, 2016

@Fleckeri can you include a few URLs below that we can use to test?

@Fleckeri
Copy link
Author

Here are some I noticed them on, but I'm sure it can be easily generalized:

https://www.twitch.tv/dotamajor
https://youtu.be/1ph_kKTURxE

For Twitch, there are periodic ads the streamer can activate, so you may need to leave it on for ~5 minutes to see. For YouTube, they are the typical beginning ads you normally see.

@dhowe
Copy link
Owner

dhowe commented Jun 11, 2016

thanks, looking into it

@dhowe dhowe self-assigned this Jun 11, 2016
@dhowe
Copy link
Owner

dhowe commented Jun 11, 2016

I'm not able to recreate this. Can you verify the version of AdNauseam you are using (in settings->about)? Also your OS and browser

@Fleckeri
Copy link
Author

Fleckeri commented Jun 11, 2016

It says it's Version 2.2.0 on the latest version of Chrome (stable 64-bit). Just to confirm, I've disabled my uBlock extension while running this. Should I leave it turned on while running AdN, or will AdN be enough on its own?

EDIT: Also when viewing the Twitch link, the AdN icon on the Chrome extension bar shows zero, while the uBlock icon shows 68 blocked elements. The blocking lists are the same.

@dhowe
Copy link
Owner

dhowe commented Jun 11, 2016

Definitely don't need both. Can you retry with just AdNauseam? Also, a screenshot of your lists (from settings/3rd-party) would be great.

@Fleckeri
Copy link
Author

Fleckeri commented Jun 11, 2016

I've been using only AdNauseum when I've encountered the above problems.

Settings
Filters

Here are screenshots of my settings and filters.

@dhowe
Copy link
Owner

dhowe commented Jun 11, 2016

Ok, I will investigate further. Also, your OS?

@Fleckeri
Copy link
Author

Windows 10 (64 bit)

@dhowe dhowe added this to the Chrome Store Launch (v2.3) milestone Jun 17, 2016
@dhowe dhowe added the Bug label Jun 17, 2016
@dhowe
Copy link
Owner

dhowe commented Jun 17, 2016

@CyrusSUEN see if you can figure out which request is getting blocked in uBlock but not adn

@dhowe dhowe removed their assignment Jun 17, 2016
dhowe added a commit that referenced this issue Jun 19, 2016
@dhowe
Copy link
Owner

dhowe commented Jun 19, 2016

This is fixed in 7552146
@CyrusSUEN please verify

@CyrusSUEN
Copy link

CyrusSUEN commented Jun 22, 2016

fixed in 7552146

Fix verified on YouTube on both Firefox and Chrome.

@dhowe dhowe changed the title AdN does not properly block video ads on YouTube, Twitch, &c. Does not properly block video ads on YouTube, Twitch, &c. Jun 22, 2016
@dhowe dhowe closed this as completed Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants