Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting Finds while no chat is running results in exception #30

Closed
mitchmastroni opened this issue Apr 6, 2018 · 1 comment
Closed

Attempting Finds while no chat is running results in exception #30

mitchmastroni opened this issue Apr 6, 2018 · 1 comment
Labels
PRIORITY: Medium

Comments

@mitchmastroni
Copy link
Collaborator

FindAsync calls scheduler.Completed(false) regardless of current RuntimeState, resulting in a DialogicException in the first line of ChatScheduler.Completed()

Should FindAsync simply do a null check on scheduler.chat?
@dhowe
Copy link
Owner

dhowe commented Apr 6, 2018 •
edited
Loading

Good catch -- fixed.

dhowe added a commit that referenced this issue Apr 6, 2018
@dhowe
fix to #30, UpdateEvent(ISendable), commenting
3fc7ae3
@dhowe dhowe closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PRIORITY: Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhowe @mitchmastroni