-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for libwebp and libheif #7
Comments
I think so, yes. I will work on that for you. |
😍 Thanks so much! |
I made an attempt at this, but vips doesn't want to compile with |
Wow that's great, thanks! Do you mind linking the issue so I can follow along? If you have a branch or something with only |
@wilg libvips/libvips#1825 was the issue. I just pushed the updated buildpack. You should have webp and heif after your next deploy. If you would like to see how I did it, check out fd24031. |
I had to revert the commit because ruby-vips was broken, I'll try to get this back into master today. |
Awesome thank you so much! |
hi @brandoncc thank you for the update!! I found myself needing the same for webp, any news on the support for those libraries? |
I'm sorry for the delay! I worked on this some more today. I have everything compiling, and vips says it can open heif files, but when I try, it tells me that the file is not a known file format. I have the work in a PR if anyone wants to try it in their application, but I don't believe it will work yet. I opened another issue on the libvips repo, and hope John can help me get this working. libvips/libvips#1945 |
Hello all,
I have not changed stack, and am still on 18.
and my buildpacks order :
I had done this Aptfile a long time ago and it is stlightly different than the one recommended (mostly no Webp or libheif reference) |
Hi @maxence33, There is a PR which should fix libheif compatibility. I just haven't had time to test it. I'll get that done today and get back to you. |
Fantastic. Yet Webp used to work with this buildpack in the past. (I think both with ImageMagick and Vips through ROR gems Shrine and ImageProcessing) (I mean Libheif and Webp from my Apt file were kinda working ?) |
Oh I think I am kinda mixing Libheif and Webp. I may just remove Libheif for now, while the PR is up, as I don't think I actually need handling HEIF and AVIF files. |
@maxence33 I think you are right, I was really surprised to hear that this buildpack had helped you with webp. Now that this is merged, You may not need webp in your apt file anymore. @wilg @rjherrera @maxence33 I sincerely apologize for this taking so long. I just merged. Let me know if any of you experience any issues. |
Would it be easy to add support for libwebp and libheif to this buildpack?
I haven't fully understood Docker yet, so I haven't had much luck myself.
The text was updated successfully, but these errors were encountered: