Ripple #28
Merged
Ripple #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Stephan, could you please transfer your fork to me ? |
|
Otherwise all good, thanks for your PR |
|
Ok will do. I also have a stellar pull request in from that same repo. Not sure how that affects things. |
codinglittlecat
pushed a commit
to codinglittlecat/diadata
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will have to use the official Ripple api for this one. The open source rippled package does not have the new Data API V2 which has the distribution API call shown here: https://developers.ripple.com/data-api-v2-tool.html#get-xrp-distribution. The circulating supply value is the distribution value. Details on the official api being the only place with the V2 Data API: https://github.com/ripple/rippled-historical-database. I actually created my own image: https://github.com/eristoddle/docker-rippled of the latest rippled version, but it only has the ws and old json-rpc api's. From what I can tell the distribution only seems to change once a week, but I will have the script run every 10 seconds and only hit the DIA api when the number changes like the other scripts.