Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoinData page #76

Closed
kaythxbye opened this issue Oct 11, 2018 · 5 comments
Closed

CoinData page #76

kaythxbye opened this issue Oct 11, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@kaythxbye
Copy link
Contributor

Re-structure the page "CoinDetails" so that it shows the general information at the top, a history chart below, and the market details on bottom. In detail these are the general building blocks:

  • The general information section will be discussed in detail for smaller design changes.
  • Integrate live market data into the already existing template from this API endpoint: https://api.diadata.org/v1/symbol/BTC (of course there is one for every currency). There should be a table with a line for each exchange displaying the name of the exchange, price, and priceYesterdayvolumeYesterdayUSD from the API.
  • When clicking on an exchange name, a list of the last 10 trades should show up. These are located at "LastTrades" for each exchange in the json the same API call from above returns. This list should include all information in the JSON at that location.
  • The price history chart should be done using Highstocks, our API will provide a json object with historical data.
@kaythxbye kaythxbye added the enhancement New feature or request label Oct 11, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.0 ETH (199.35 USD @ $199.35/ETH) attached to it as part of the DIA fund__.__

@gitcoinbot
Copy link

gitcoinbot commented Oct 11, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 months, 4 weeks ago.
Please review their action plans below:

1) mul1sh has been approved to start work.

I'll implement the changes as required

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@mul1sh Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@mul1sh Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.0 ETH (214.32 USD @ $214.32/ETH) has been submitted by:

  1. @mul1sh

@kaythxbye please take a look at the submitted work:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants