Fixed bug that miter line joins are cut of early and one with stacked clippings. #37
Conversation
…g a high miter limit.
Before this several stacked clips were just printed as several paths in the clipPath element. But according to the SVG standard this means they are OR'ed together, although we want them to be intersected. I changed this by building them up around the clipped element hierarchical, which leads to intersection according to the SVG spec. I tested this in the chart drawing tests and it seems to work.
|
In my perspective: If you can't change it manually try to emulate as if there was none. So maybe it would be useful to add a diagrams attribute for this. |
|
See diagrams/diagrams-lib@7be5cdf . Should we also change |
|
I think it would be good to change The given miter limit attribute misses semantics. Can someone write them done properly? |
|
Postscript and cairo both use a default miter limit of 10:
I can't find anything officially specifying the default miter limit used by SVG. To keep things simple we should probably just specify 10 as the default miter limit for diagrams too. |
|
The default for SVG is 4. Spec: miter limit = 1/sin(angle/2) |
| @@ -193,7 +198,7 @@ instance Backend SVG R2 where | |||
| -- primitives before passing them to render. | |||
| renderDia SVG opts d = | |||
| doRender SVG opts' . mconcat . map renderOne . prims $ d' | |||
| where (opts', d') = adjustDia SVG opts d | |||
| where (opts', d') = adjustDia SVG opts $ setDefault2DAttributes d | |||
There was a problem hiding this comment.
adjustDia already calls setDefault2DAttributes (via adjustDia2D) so this is calling setDefault2DAttributes twice.
There was a problem hiding this comment.
My bad I will remove that again then.
|
I hope this can be merged now, because after this I will send the pull requests for the font-embedding stuff. |
|
So is this now superseded by #38 ? |
|
Yes |
|
Closing in favor of #38. |
Fixed bug that miter line joins are cut of early by explicitly setting a high miter limit.
I noticed that the miter limit was left at its default value by the SVG backend while looking at the Charts drawing test for lines. I don't know if a even higher value would be good here or an actual miter limit attribute for Diagrams, but this value works for my use cases.
I also fixed a issue with stacked clippings. Before this several stacked clips were just printed as several paths in the clipPath element. But according to the SVG spec this means they are OR'ed together, although we want them to be intersected. I changed this by building them up around the clipped element hierarchical, which leads to intersection according to the SVG spec. I tested this in the chart drawing tests and it seems to work.