Font embedding changes #38
Conversation
I think this is more clear.
…g a high miter limit.
Before this several stacked clips were just printed as several paths in the clipPath element. But according to the SVG standard this means they are OR'ed together, although we want them to be intersected. I changed this by building them up around the clipped element hierarchical, which leads to intersection according to the SVG spec. I tested this in the chart drawing tests and it seems to work.
| } | ||
| deriving Show |
There was a problem hiding this comment.
Why did you remove this Show instance? Is S.Svg not an instance of Show? The Show instance is needed by diagrams-builder to include backend options in the hash of a diagram (so that the diagram will be recompiled if the options change).
There was a problem hiding this comment.
Yes, I removed it because S.Svg is not an instance of Show. I wanted to replace it but I wasn't sure what would be appropriate. Should I output the XML?
There was a problem hiding this comment.
OK, I see that Svg = Markup = MarkupM () is indeed not an instance of Show, so we can no longer derive a Show instance. We could implement a custom Show instance which simply serializes the SVG. Probably that's what we should do for now, to avoid breaking diagrams-builder at the moment. But this is not really in the spirit of Show. Probably what we should actually do is switch to using Hashable instead of Show in diagrams-builder. Filed diagrams/diagrams-builder#5.
There was a problem hiding this comment.
Then I will just insert the SVG as a XML string and provide a custom instance.
|
Thanks! |
This pull request already contains all bug fixed from master in addition to the changes needed to embed fonts in SVGs.
Basically I only added a optional SVG
defssection that can be filled with user content (e.g. font data).