-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font embedding changes #38
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
aa79ed6
Added defs section to the SVG skeleton.
0d5211b
The definitions are not passed as maybe value.
deaaab2
Added Options entry for the additional custom definitions.
ce8eccd
Merge branch 'master' into font-embedding
b182d75
Merge branch 'master' of github.com:diagrams/diagrams-svg into font-e…
086f543
Fixed bug that miter line joins are cut of early by explicitly settin…
6197213
Merge branch 'master' into font-embedding
345b9b7
Fixed issue with stacked clipping.
ef69b7c
Merge branch 'master' into font-embedding
9a5b658
Added support for the miter limit attribute.
ebfd14a
Merge branch 'master' into font-embedding
09bbb03
Corrected copy and paste error with the miter limit.
237cd43
Merge branch 'master' into font-embedding
2a4d926
Removed setting standard attributes again, because it is allready cal…
86a2688
Added show instance for SVGOptions.
f434e40
Show instance now prints in one line.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this
Show
instance? IsS.Svg
not an instance ofShow
? TheShow
instance is needed bydiagrams-builder
to include backend options in the hash of a diagram (so that the diagram will be recompiled if the options change).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I removed it because S.Svg is not an instance of Show. I wanted to replace it but I wasn't sure what would be appropriate. Should I output the XML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see that
Svg = Markup = MarkupM ()
is indeed not an instance ofShow
, so we can no longer derive aShow
instance. We could implement a customShow
instance which simply serializes the SVG. Probably that's what we should do for now, to avoid breakingdiagrams-builder
at the moment. But this is not really in the spirit ofShow
. Probably what we should actually do is switch to usingHashable
instead ofShow
indiagrams-builder
. Filed diagrams/diagrams-builder#5.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I will just insert the SVG as a XML string and provide a custom instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 86a2688 and f434e40