Wait one frame before clean to avoid disconnecting internal ONESHOT connections #2072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot seemed to try to disconnect a signal we had already cleared (in timeline.clean()). Unfortunately it seemed pretty hard to differentiate these signals from other signals (because I wasn't allowed to access it's object). Luckily it is solved by simply waiting a frame because godot will have removed the connection on the next frame.
@Atlinx would love if you could try this!