Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove autoused fixtures + set dont_patch_engine marker in plugin - DM-6561 #54

Merged
merged 4 commits into from
Jul 29, 2022

Conversation

hadrien
Copy link
Member

@hadrien hadrien commented Jul 29, 2022

Description

  • The autoused fixtures force a connection to postgres server even if the test being run does not require a connection to postgres;
  • The dont_patch_engine marker is now set by plugin rather than in conftest;
  • Removed unused fixture sqla_version_tuple;

Related JIRA issues

Related PRs

  • dialoguemd/engage#22

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #54 (d48b6e7) into master (47c94a9) will increase coverage by 0.63%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master       #54      +/-   ##
===========================================
+ Coverage   99.36%   100.00%   +0.63%     
===========================================
  Files           4         4              
  Lines         317       318       +1     
  Branches       22        21       -1     
===========================================
+ Hits          315       318       +3     
+ Misses          2         0       -2     
Flag Coverage Δ
sqlalchemy1.3-asyncpg-aws_rds_iam 73.58% <75.00%> (+0.71%) ⬆️
sqlalchemy1.3-asyncpg-noaws_rds_iam 71.06% <75.00%> (+0.72%) ⬆️
sqlalchemy1.3-noasyncpg-aws_rds_iam 73.27% <75.00%> (+0.71%) ⬆️
sqlalchemy1.3-noasyncpg-noaws_rds_iam 70.75% <75.00%> (+0.72%) ⬆️
sqlalchemy1.4-asyncpg-aws_rds_iam 94.33% <75.00%> (-0.30%) ⬇️
sqlalchemy1.4-asyncpg-noaws_rds_iam 91.82% <75.00%> (-0.29%) ⬇️
sqlalchemy1.4-noasyncpg-aws_rds_iam 79.24% <75.00%> (+0.69%) ⬆️
sqlalchemy1.4-noasyncpg-noaws_rds_iam 76.72% <75.00%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fastapi_sqla/_pytest_plugin.py 100.00% <100.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e35155...d48b6e7. Read the comment docs.

@hadrien hadrien requested review from edouardlp and vicrep July 29, 2022 15:37
Copy link
Contributor

@edouardlp edouardlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Check codecov, it seems that this change is leading some fixtures to no longer being executed as part of this repo's tests and thus drops coverage.

@hadrien hadrien changed the title fix: remove autoused fixtures - DM-6561 fix: remove autoused fixtures + set dont_patch_engine marker in plugin - DM-6561 Jul 29, 2022
@hadrien hadrien merged commit d3235bf into master Jul 29, 2022
@hadrien hadrien deleted the fix/DM-6561/fixtures branch July 29, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants