Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dials.image_viewer does not update results of bottom buttons for series of '.expt' #1734

Closed
elena-pascal opened this issue Jun 3, 2021 · 6 comments · Fixed by #1761
Closed

dials.image_viewer does not update results of bottom buttons for series of '.expt' #1734

elena-pascal opened this issue Jun 3, 2021 · 6 comments · Fixed by #1761
Labels
bug dials.image_viewer

Comments

@elena-pascal
Copy link
Contributor

elena-pascal commented Jun 3, 2021 •
edited

When loading a series of .expt in dials.image_viewer the buttons at the bottom (mean... threshold) don't seem to update results when moving through the images.

If I use instead the raw files (dials.image_viewer image_*.cbf), the results of buttons at the bottom update as expected.
@graeme-winter
Copy link
Contributor

OK interesting it worked OK for me there - what platform was this?

@graeme-winter
Copy link
Contributor

Also: what was the command-line used to start dials.image_viewer?

@elena-pascal
Copy link
Contributor Author

hmm. I am on Ubuntu 20.04.
I used dials.image_viewer imported_*.expt where imported_###.expt is a list of imported experiments as imported by dials.stills_process. Is it not meant to be used like this?
Adding the reflections doesn't change the observed effect.

@graeme-winter
Copy link
Contributor

Verified & reproduced thank you

This appears to be a bug in the implementation of the buttons - if you load an image which is not the first one, then select one of the buttons, you end up with the processed version of the 1st image.

This would explain why it does not update when you move from one to the next.

@graeme-winter
Copy link
Contributor

Verified & reproduced thank you

This appears to be a bug in the implementation of the buttons - if you load an image which is not the first one, then select one of the buttons, you end up with the processed version of the 1st image.

This would explain why it does not update when you move from one to the next.

Correction

It shows the first image you selected not image-view with over and over again, not the first image.

To reproduce:

dials.stills_process unit_cell=97,97,97,90,90,90 space_group=p23 ./*cbf
dials.image_viewer idx-merlin0047_1748*imported.expt

@graeme-winter graeme-winter mentioned this issue Jun 22, 2021
Closed
@graeme-winter
Copy link
Contributor

OK, I found it 🙂

graeme-winter added a commit that referenced this issue Jun 22, 2021
@graeme-winter
Remove cache of Kabsch debugging
7b5ee3b 
Was broken anyway for stills as image.index is always 0

Fixes #1734

Removed now redundant request dict as well
@graeme-winter graeme-winter mentioned this issue Jun 22, 2021
Merged
ndevenish pushed a commit that referenced this issue Jun 28, 2021
@graeme-winter
Fix image_viewer display of spotfinding intermediates for stills (#1761)
0db27df 
By simply computing a hash of the settings including the imageset this
still fixes #1734 whilst leaving #1213 fixed. Changing a request dict
to a simple hash of a tuple of the settings stops a future reader from
working through the code looking for where that request is sent to.

Also named the hash the same as the object which is hashed, to make the
connection clearer.
ndevenish pushed a commit that referenced this issue Jun 28, 2021
@graeme-winter @ndevenish
Fix image_viewer display of spotfinding intermediates for stills (#1761)
9cb8195 
By simply computing a hash of the settings including the imageset this
still fixes #1734 whilst leaving #1213 fixed. Changing a request dict
to a simple hash of a tuple of the settings stops a future reader from
working through the code looking for where that request is sent to.

Also named the hash the same as the object which is hashed, to make the
connection clearer.
DiamondLightSource-build-server added a commit that referenced this issue Jun 28, 2021
@DiamondLightSource-build-server
DIALS 3.5.2
b44b3af 
Bugfixes
--------

- ``dials.image_viewer``: Fix display of spotfinding intermediates (threshold, dispersion, etc) when viewing multiple still experiments (#1734)
- ``dials.image_viewer``: Stacking images no longer gives incorrect results for multi-sweep data beyond the first sweep (#1758)
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug dials.image_viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove cache of Kabsch debugging dials/dials
2 participants
@graeme-winter @elena-pascal