Pin setuptools version #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpalms
force-pushed
the
fix-gym-0.21-requirements
branch
from
d9756a1
to
74e7e47
Compare
alexpalms
commented
Jun 25, 2023
| @@ -32,8 +32,7 @@ | |||
| install_requires=[ | |||
| 'pip>=21', | |||
| 'importlib-metadata<=4.12.0; python_version <= "3.7"', # problem with gym for importlib-metadata==5.0.0 and python <=3.7 | |||
| 'wheel==0.38.4', # Required until we can upgrade to gym >= 0.22.0 | |||
| 'setuptools', | |||
| 'setuptools<=66.0.0', # Required until we can upgrade to gym >= 0.22.0 | |||
There was a problem hiding this comment.
@discordianfish So, to recap:
gym<=0.21is not compatible withwheel+setuptoolslatest versions, more specifically:wheel>0.38.4setuptools>66.0.0
- New
wheelpackages raise an error that:- In CICD is catched and make the pipeline fail
- In local dev envs is ignored (but shown) and make the installation succeed
- New
setuptoolspackages make the installation fail in both CICD and local dev envs
Considering that:
- Pinning
wheelindiambra-arenarequirements does not solve the CICD issue aswheelis needed before the package installation, thus we need to add the specific wheel package anyways - New version of
wheeldoes not prevent the package to be installed in local envs, but it does show an error message
Here I am only pinning setuptools package, as this solves the issue until we upgrade gym version.
Do you suggest to also pin wheel even if it does not make the installation fail in local envs to avoid showing the error?
There was a problem hiding this comment.
No this is perfect. Also thanks a lot for the detailed explanation!
discordianfish
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.