Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin setuptools version #78

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Pin setuptools version #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
install_requires=[
'pip>=21',
'importlib-metadata<=4.12.0; python_version <= "3.7"', # problem with gym for importlib-metadata==5.0.0 and python <=3.7
'wheel==0.38.4', # Required until we can upgrade to gym >= 0.22.0
'setuptools',
'setuptools<=66.0.0', # Required until we can upgrade to gym >= 0.22.0
Copy link
Member Author

@alexpalms alexpalms Jun 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@discordianfish So, to recap:

  • gym<=0.21 is not compatible with wheel+setuptools latest versions, more specifically:
    • wheel>0.38.4
    • setuptools>66.0.0
  • New wheel packages raise an error that:
    • In CICD is catched and make the pipeline fail
    • In local dev envs is ignored (but shown) and make the installation succeed
  • New setuptools packages make the installation fail in both CICD and local dev envs

Considering that:

  • Pinning wheel in diambra-arena requirements does not solve the CICD issue as wheel is needed before the package installation, thus we need to add the specific wheel package anyways
  • New version of wheel does not prevent the package to be installed in local envs, but it does show an error message

Here I am only pinning setuptools package, as this solves the issue until we upgrade gym version.

Do you suggest to also pin wheel even if it does not make the installation fail in local envs to avoid showing the error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is perfect. Also thanks a lot for the detailed explanation!

'distro>=1',
'gym<=0.21.0',
'inputs',
Expand Down