-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds gtk.TreeView example #1
Adds gtk.TreeView example #1
Conversation
gtk4/treeview/treeview.go
Outdated
// FIXME: doesn't seem to work | ||
//listStore.Set(&iter, | ||
// []int{COLUMN_NAME, COLUMN_COMMENT}, | ||
// []glib.Value{*glib.NewValue(name), *glib.NewValue(comment)}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diamondburned any idea what's going on here? the value of a column is missing if I use this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the dereference here may cause glib.Value
to be freed earlier
than it should be, because that throws away the Finalizer. This would be a bug
in pkg/core/glib
, I think.
@diamondburned started playing with the bindings today. Quite pleasant to use. Nice job!. Some early feedback:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR blocks on a separate GLib issue.
Edit: tracking in diamondburned/gotk4#34.
gtk4/treeview/treeview.go
Outdated
// FIXME: doesn't seem to work | ||
//listStore.Set(&iter, | ||
// []int{COLUMN_NAME, COLUMN_COMMENT}, | ||
// []glib.Value{*glib.NewValue(name), *glib.NewValue(comment)}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the dereference here may cause glib.Value
to be freed earlier
than it should be, because that throws away the Finalizer. This would be a bug
in pkg/core/glib
, I think.
Commit e977c64 in |
9cfd990
to
772f91c
Compare
It seems like using |
gotk4 commit 318362c fixed this. It was an issue to do with how C's |
Nice spelunking, that fixed it. Bumped gotk4 also. |
No description provided.