Skip to content

Commit

Permalink
Fix eye not stopping all processes
Browse files Browse the repository at this point in the history 
Fixes #6685. See kostya/eye@866ecd0
  • Loading branch information
Steffen van Bergerem committed Feb 11, 2016
1 parent c9a3256 commit 269512c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion script/server
View file
Expand Up @@ -202,4 +202,4 @@ else
fi
echo ""

exec bin/bundle exec loader_eye -st -c config/eye.rb
exec bin/bundle exec loader_eye --stop_all -c config/eye.rb

This comment has been minimized.

Sign in to view

Copy link
@FinnWoelm

FinnWoelm Jul 13, 2017

Contributor

Hi there! First of all: Amazing work on all this! So in ❤️

Secondly: What's the rationale for using loader_eye? According to the official wiki, "loader_eye is just internal server runner (without daemonization), not for common usage, can be used for test eye server".

Rather than telling people to use nohup/screen/tmux when running ./script/server [e.g. here], wouldn't it be preferable to use the standard functionality of eye that already runs as a daemon?

For example, I'm starting my production server by running nohup ./script/server &.
Doing this, I don't actually know if the server was started correctly or not, since all output is directed into a file. I remain unaware of messages such as "You're running in production mode without having your assets precompiled..." and other fatal output until I actually check that file.

If eye was set up to start as a daemon, I would not have to run server/script as a background process, which would mean that I would either see one of these fatal messages or I would see "Eye started! ㋡".

2 comments on commit 269512c

@jhass
Copy link
Member

@jhass jhass commented on 269512c Jul 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The greater ecosystem is moving towards not doing self demonization, see http://www.mikeperham.com/2014/09/22/dont-daemonize-your-daemons/ for some rationale for that move.

@FinnWoelm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned something new, thank you!

Please sign in to comment.