Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPV photo background removal, #4407

Merged

Conversation

rogerbraun
Copy link
Contributor

This is about #3741.

It deactivates the photo backdrop feature by always returning false when asked if the current template should return a photo backdrop. I did not want to completely remove the backdrop templates, as I think they might be needed again in the future.

@goobertron
Copy link

Does that mean that the photo will not be displayed at all, or that it will be displayed as part of the post, as it would be in the stream? First one bad, second one good!

@rogerbraun
Copy link
Contributor Author

The photo will be displayed as part of the post. It look just like the current view when you have multiple photos in a post.

@goobertron
Copy link

Great, sounds really good. Thanks for your reply.

jhass added a commit that referenced this pull request Aug 16, 2013
@jhass jhass merged commit e9977af into diaspora:develop Aug 16, 2013
@jhass
Copy link
Member

jhass commented Aug 16, 2013

Thanks!

@rivendale2010
Copy link
Contributor

i like this a lot! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants