[MRG] fix LCA_Database.gather(...) call to use LCA_Database.best_containment(...)
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctb
changed the title
LCA_Database.gather(...) call to use LCA_Database.best_containment(...)
|
One of the tests is failing ( |
|
yep, and I'm also fighting with some out of date conda environments 😬 . but farm is down so that's also delaying work. |
|
ok @taylorreiter ready for review and merge ;) |
|
well I was too late but I looked at it anyway and it looks good to me :) |
|
On Wed, Aug 24, 2022 at 06:31:12AM -0700, Taylor Reiter wrote:
well I was too late but I looked at it anyway and it looks good to me :)
no worries ;)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sourmash-bio/sourmash#2116, I renamed
Index.gathertoIndex.best_containment, and that broke charcoal.This PR fixes that, adds a test, and also:
Fixes #224