-
Notifications
You must be signed in to change notification settings - Fork 295
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1847 from dib-lab/relax-checklist
[MRG] Relax the PR checklist
- Loading branch information
Showing
1 changed file
with
26 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,27 @@ | ||
- [ ] Is it mergeable? | ||
- [ ] `make test` Did it pass the tests? | ||
- [ ] `make clean diff-cover` If it introduces new functionality in | ||
`scripts/` is it tested? | ||
- [ ] `make format diff_pylint_report cppcheck doc pydocstyle` Is it well | ||
formatted? | ||
- [ ] Did it change the command-line interface? Only backwards-compatible | ||
additions are allowed without a major version increment. Changing file | ||
formats also requires a major version number increment. | ||
- [ ] For substantial changes or changes to the command-line interface, is it | ||
documented in `CHANGELOG.md`? See [keepachangelog](http://keepachangelog.com/) | ||
for more details. | ||
|
||
---------------------------------------- | ||
|
||
> <u>Message from the khmer maintainers</u>: | ||
> | ||
> *Please provide a description of the pull request above, including a | ||
> reasonable level of detail and references to any relevant threads. After | ||
> creating the pull request, complete and mark the checklist below. If any item | ||
> is not applicable, feel free to remove it or mark it as complete. If you are | ||
> unsure about any item, feel free to ask about it before or during code | ||
> review.* | ||
> | ||
> *When you are ready for the pull request to be reviewed, please post a comment | ||
> with a message such as "Ready for review!"* | ||
- [ ] Is any new functionality in tested? (This can be checked with | ||
`make clean diff-cover` or the CodeCov report that is automatically | ||
generated following a successful CI build.) | ||
- [ ] Was a spellchecker run on the source code and documentation after | ||
changes were made? | ||
- [ ] Do the changes respect streaming IO? (Are they | ||
tested for streaming IO?) | ||
changes were made? | ||
- [ ] Have any changes to the command-line interface been explicitly described? | ||
Only backwards-compatible additions are allowed without a major version | ||
increment. Changing file formats also requires a major version number | ||
increment. | ||
- [ ] Have any substantial changes been documented in `CHANGELOG.md`? See | ||
[keepachangelog](http://keepachangelog.com/) for more details. | ||
- [ ] Do the changes respect streaming I/O? (Are they tested for streaming I/O?) |