Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setup.cfg to have stop=FALSE #1124

Closed
ctb opened this issue Jun 29, 2015 · 2 comments
Closed

Change setup.cfg to have stop=FALSE #1124

ctb opened this issue Jun 29, 2015 · 2 comments

Comments

@ctb
Copy link
Member

ctb commented Jun 29, 2015

Back When, when setup.cfg was put into place to provide default parameters, -x/stop=TRUE was set as default. This was more or less chosen randomly.

It has been bugging me increasingly ever since, for a few reasons:

  • it is very rare for me to break dozens of tests at once, but it is quite common to break one test intentionally (which then stops the test running) while breaking three tests unintentionally (which then isn't reported).
  • the compiled-C-code vs git-version-check breaks a lot on me and stops the tests, even when I'm only making Python changes that don't need recompilation;
  • it's actually impossible to unset stop=TRUE at the command line to nosetests;

as such, I've actually created my own copy of setup.cfg with 'stop=FALSE' set and I run that myself. But I actually think the default should be stop=TRUE for everyone.

A separate and longer term fix might be to make the test running faster, but that's out of scope for this issue.

Any objections?

@mr-c
Copy link
Contributor

mr-c commented Jun 29, 2015

I also hate this default. +1 to dropping the line

@bocajnotnef
Copy link
Contributor

Closing #1124, changes merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants