Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--max-memory-usage input #1259

Closed
macmanes opened this issue Aug 16, 2015 · 9 comments
Closed

--max-memory-usage input #1259

macmanes opened this issue Aug 16, 2015 · 9 comments

Comments

@macmanes
Copy link

It seems that --max-memory-usage should take the samtools-like human readable options, instead of what it does now. So, instead of --max-memory-usage 4e10, wouldn't --max-memory-usage 8G or --max-memory-usage 400M be easier for users to specify?

@mr-c mr-c added this to the 2.0+ milestone Aug 18, 2015
@mr-c
Copy link
Contributor

mr-c commented Aug 18, 2015

Howdy @macmanes!

This is a great idea, thank you for suggesting it. I've added it to the Milestone for the release after 2.0.

@ghost
Copy link

ghost commented Mar 20, 2016

I will work on this

@mr-c
Copy link
Contributor

mr-c commented Mar 20, 2016

@Blubse Great! Let us know if you have any questions.

@ghost
Copy link

ghost commented Mar 24, 2016

Is it OK to use a library which is licensed under the MIT license?

@ctb
Copy link
Member

ctb commented Mar 24, 2016

@Blubse should be ok, but in general we want to minimize dependencies. What library are you thinking of?

@ghost
Copy link

ghost commented Mar 24, 2016

https://humanfriendly.readthedocs.org/ But If you don't want an extra library it should not take me too long to reimplement the needed function.

@ctb
Copy link
Member

ctb commented Mar 24, 2016

Happy to consider. We can also make it an optional dependency. Pure Python dependencies are much easier than not, too.

What is the full range of functionality you're thinking of here? I'm not even sure what samtools supports, frankly.

@standage
Copy link
Member

standage commented Jun 29, 2016

I also stumbled upon the humanfriendly package, but unfortunately it doesn't handle units correctly. :(

standage added a commit that referenced this issue Jun 30, 2016
@ctb ctb closed this as completed in 45a5195 Jul 6, 2016
@standage
Copy link
Member

standage commented Jul 6, 2016

@macmanes Human-friendly memory requests are available from the current master, and will be included in the v2.1 release. It allows K, M, G, or T as a suffix when requesting memory.

Dmarch28 pushed a commit to Dmarch28/khmer that referenced this issue Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants