-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--max-memory-usage input #1259
Comments
Howdy @macmanes! This is a great idea, thank you for suggesting it. I've added it to the Milestone for the release after 2.0. |
I will work on this |
@Blubse Great! Let us know if you have any questions. |
Is it OK to use a library which is licensed under the MIT license? |
@Blubse should be ok, but in general we want to minimize dependencies. What library are you thinking of? |
https://humanfriendly.readthedocs.org/ But If you don't want an extra library it should not take me too long to reimplement the needed function. |
Happy to consider. We can also make it an optional dependency. Pure Python dependencies are much easier than not, too. What is the full range of functionality you're thinking of here? I'm not even sure what samtools supports, frankly. |
I also stumbled upon the humanfriendly package, but unfortunately it doesn't handle units correctly. :( |
@macmanes Human-friendly memory requests are available from the current master, and will be included in the v2.1 release. It allows K, M, G, or T as a suffix when requesting memory. |
* Closes dib-lab#1259. * Additional test coverage
It seems that
--max-memory-usage
should take the samtools-like human readable options, instead of what it does now. So, instead of--max-memory-usage 4e10
, wouldn't--max-memory-usage 8G
or--max-memory-usage 400M
be easier for users to specify?The text was updated successfully, but these errors were encountered: