Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khmer 2.1 should not add major new dependencies like Cython #1624

Closed
ctb opened this issue Feb 17, 2017 · 1 comment
Closed

khmer 2.1 should not add major new dependencies like Cython #1624

ctb opened this issue Feb 17, 2017 · 1 comment
Milestone

Comments

@ctb
Copy link
Member

ctb commented Feb 17, 2017

Since these conversations on slack apparently got lost in the enthusiasm of refactoring, I thought I'd write down my reasoning behind asking for a 2.1 release before we merge in the major Cython refactoring in #1595.

  1. Cython is going to break some installs in unpredictable ways.

  2. The current master is pretty well tested and vetted, and it has bug fixes and performance improvements that will make users' lives better without breaking anything (due to semantic versioning requirements).

  3. The first two reasons combined imply that we would incur some significant support burden from releasing a Cython-based version, whereas we would incur little to no additional support burden from releasing the current master as khmer 2.1.

  4. I predict that there will be some reasonably annoying and significant bugs and compilation challenges with the Cython branch that will cost us dev time and slow down any Cython-based release. Best to let the Cython branch delay development and release of 3.0 with a well-tested 2.1 update out there in the wild.

  5. A sourmash 2.0 release depends on a khmer 2.1, and sourmash 2.0 should be ready soon-ish.

  6. It looks like the transition to oxli is well under way in Split CPython and begin the Cython revolution #1595 so we can plan a bunch of changes with 3.0, rather than pushing out a 3.0 sooner and confusing people with a 4.0. (Not sure how this will actually work out, but it seems reasonable).

So, in sum, I'm cautiously optimistic about Cython but there is enough potential breakage in the refactoring that I want to get khmer 2.1 out first.

@ctb
Copy link
Member Author

ctb commented Feb 17, 2017

Incidentally, #1623 is another great example of why we do want to get 2.1 out soon, so that we can add exciting new command line features and break backwards compatibility of scripts, on top of all the cool let's-build-on-khmer stuff that's motivating @standage and @camillescott's. So I'm enthusiastic about getting 2.1 out. But it's not something I can move forward on my own until April sometime.

@standage standage modified the milestone: 2.1 Feb 23, 2017
@betatim betatim closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants