Update partition map file format to be more robust

[ctb]

The partition map file format (see SubsetPartition::merge_from_disk) is not robust to truncation. In particular, the loading function just reads until it encounters an EOF. Most of our other file formats store the number of items to read in the header info.

@mr-c, I can fix this as part of #333, but I was unsure as to whether our file formats are covered by semantic versioning. Your thoughts? I don't think it's urgent.

[mr-c]

Our file formats are indeed covered by the semantic versioning agreement,
yep.

How about outputting the number of records after reading or writing the
partition map?
On May 23, 2014 2:57 AM, "C. Titus Brown" notifications@github.com wrote:

The partition map file format (see SubsetPartition::merge_from_disk) is
not robust to truncation. In particular, the loading function just reads
until it encounters an EOF. Most of our other file formats store the number
of items to read in the header info.

@mr-c https://github.com/mr-c, I can fix this as part of #333#333,
but I was unsure as to whether our file formats are covered by semantic
versioning. Your thoughts? I don't think it's urgent.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/437
.

[ctb]

On Fri, May 23, 2014 at 09:05:17AM -0700, Michael R. Crusoe wrote:

Our file formats are indeed covered by the semantic versioning agreement,
yep.

How about outputting the number of records after reading or writing the
partition map?

What, to stdout? I suppose we could do that but it's hardly a fix ;).

OK, well, we'll put it on the list for 2.0, then!

cheers,
--titus

On May 23, 2014 2:57 AM, "C. Titus Brown" notifications@github.com wrote:

The partition map file format (see SubsetPartition::merge_from_disk) is
not robust to truncation. In particular, the loading function just reads
until it encounters an EOF. Most of our other file formats store the number
of items to read in the header info.

@mr-c https://github.com/mr-c, I can fix this as part of #333#333,
but I was unsure as to whether our file formats are covered by semantic
versioning. Your thoughts? I don't think it's urgent.

???
Reply to this email directly or view it on GitHubhttps://github.com//issues/437
.

---

Reply to this email directly or view it on GitHub:

#437 (comment)

C. Titus Brown, ctb@msu.edu

[mr-c]

Fixed in #1048