Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastq-to-fasta.py default of dropping reads with 'N's is non-obvious and confusing #657

Closed
mr-c opened this issue Nov 14, 2014 · 8 comments
Closed

fastq-to-fasta.py default of dropping reads with 'N's is non-obvious and confusing #657

mr-c opened this issue Nov 14, 2014 · 8 comments
Labels
low-hanging-fruit Python

Comments

@mr-c
Copy link
Contributor

mr-c commented Nov 14, 2014

No description provided.

@ACharbonneau
Copy link
Contributor

I'm working on this

@ACharbonneau
Copy link
Contributor

@mr-c
Right now the program says the default is to leave in reads with N's, but it actually drops them by default.
I can make them match, but is the stated default correct? Or the current behavior?

@mr-c
Copy link
Contributor Author

mr-c commented Jan 13, 2015

Lets update the documentation and keep the behaviour as is

@ctb
Copy link
Member

ctb commented Feb 20, 2015

ping @ACharbonneau - can we liberate this issue for someone else to tackle?

@ACharbonneau
Copy link
Contributor

Sorry! Got distracted. Just submitted pull request.

@luizirber
Copy link
Member

This is being worked on PR #814

@ctb
Copy link
Member

ctb commented Jun 13, 2015

#1036 is relevant (how to handle Ns).

@mr-c
Copy link
Contributor Author

mr-c commented Jul 30, 2015

Fixed in #814

@mr-c mr-c closed this as completed Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging-fruit Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luizirber @ctb @mr-c @ACharbonneau