Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'cython all the things' and 'allow -H for k > 32' code. #1626

Closed

Conversation

ctb
Copy link
Member

@ctb ctb commented Feb 17, 2017

Merge #1623 into #1595, as a trial.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@ctb ctb changed the title Merge/cython all and long k options Merge 'cython all the things' and 'allow -H for k > 32' code. Feb 17, 2017
@ctb ctb changed the base branch from master to feature/cython_all_the_things February 17, 2017 14:26
@ctb
Copy link
Member Author

ctb commented Feb 17, 2017

This merge wasn't so bad...

@camillescott
Copy link
Member

camillescott commented Feb 17, 2017 via email

@ctb
Copy link
Member Author

ctb commented Feb 17, 2017 via email

@standage
Copy link
Member

We can close this right?

@standage standage closed this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants