Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try out guzzle theme for documentation #1630

Merged
merged 3 commits into from Mar 3, 2017
Merged

try out guzzle theme for documentation #1630

merged 3 commits into from Mar 3, 2017

Conversation

ctb
Copy link
Member

@ctb ctb commented Feb 19, 2017

Our old sphinx theme is kind of outdated looking ;). What do y'all think?

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@ctb
Copy link
Member Author

ctb commented Feb 19, 2017

@codecov-io
Copy link

codecov-io commented Feb 19, 2017

Codecov Report

Merging #1630 into master will decrease coverage by -0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
- Coverage   69.81%   69.79%   -0.02%     
==========================================
  Files          66       66              
  Lines        8971     8970       -1     
  Branches     3060     3060              
==========================================
- Hits         6263     6261       -2     
- Misses       1025     1026       +1     
  Partials     1683     1683
Impacted Files Coverage Δ
lib/storage.hh 89.28% <0%> (-0.52%)
lib/hashtable.cc 55.18% <0%> (-0.22%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbb3c1...b535de1. Read the comment docs.

@betatim
Copy link
Member

betatim commented Feb 20, 2017

Looks shiny ✨ Fine with me

@standage
Copy link
Member

I approve this message.

@betatim betatim merged commit f66fd4e into master Mar 3, 2017
@betatim betatim deleted the docs/guzzle_theme branch March 3, 2017 14:00
@betatim
Copy link
Member

betatim commented Mar 3, 2017

Shiny new docs should appear soon.

@ctb
Copy link
Member Author

ctb commented Mar 3, 2017

@betatim
Copy link
Member

betatim commented Mar 3, 2017

on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants