Remove debugging output from filter-abundant-single.py #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 90 90
Lines 11429 11428 -1
Branches 3035 3035
======================================
Hits 6 6
+ Misses 11423 11422 -1
Continue to review full report at Codecov.
|
…uiet and test_filter_abund_1_singlefile_quiet
|
note you can also direct to /dev/null in the ipython notebook
…On Fri, Jun 30, 2017 at 07:24:24AM +0000, Will Trimble wrote:
This debugging output was producing 30,000 lines of standard out in the kmer-abundance-distribuion.ipynb lesson.
- [ ] Is it mergeable?
- [ ] `make test` Did it pass the tests?
- [ ] `make clean diff-cover` If it introduces new functionality in
`scripts/` is it tested?
- [ ] `make format diff_pylint_report cppcheck doc pydocstyle` Is it well
formatted?
- [ ] Did it change the command-line interface? Only backwards-compatible
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
- [ ] For substantial changes or changes to the command-line interface, is it
documented in `CHANGELOG.md`? See [keepachangelog](http://keepachangelog.com/)
for more details.
- [ ] Was a spellchecker run on the source code and documentation after
changes were made?
- [ ] Do the changes respect streaming IO? (Are they
tested for streaming IO?)
You can view, comment on, or merge this pull request online at:
#1740
-- Commit Summary --
* Removed debugging output
-- File Changes --
M scripts/filter-abund-single.py (1)
-- Patch Links --
https://github.com/dib-lab/khmer/pull/1740.patch
https://github.com/dib-lab/khmer/pull/1740.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1740
--
C. Titus Brown, ctbrown@ucdavis.edu
|
|
Which I did last night with wltrimbl/angus@1300f84 ngs-docs/angus#242 |
|
Looks good - fill in the checkboxes and ask for a review if you want it merged! |
|
Ready for review |
micjohn123
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This debugging output was producing 30,000 lines of standard out in the kmer-abundance-distribution.ipynb lesson.
make testDid it pass the tests?make clean diff-coverIf it introduces new functionality inscripts/is it tested?make format diff_pylint_report cppcheck doc pydocstyleIs it wellformatted?
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
documented in
CHANGELOG.md? See keepachangelogfor more details.
changes were made?
tested for streaming IO?)